Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 2/3] fix warning of not used variable | Date | Fri, 5 Dec 2008 10:31:07 +1030 |
| |
On Thursday 04 December 2008 22:06:33 Américo Wang wrote: > On Thu, Dec 4, 2008 at 1:00 AM, Jianjun Kong <jianjun@zeuux.org> wrote: > > fix this warning: > > kernel/module.c:824: warning: 'print_unload_info' defined but not used > > print_unload_info() just used when CONFIG_PROC_FS was defined. > > > > Signed-off-by: Jianjun Kong <jianjun@zeuux.org> > > Reviewed-by: WANG Cong <wangcong@zeuux.org>
My main concern is that this adds two new #ifdef sections. How about marking both cases "inline" instead?
Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |