Messages in this thread | | | Date | Sat, 6 Dec 2008 01:16:34 +0000 | From | "Américo Wang" <> | Subject | Re: [PATCH][UML] Boot broken due to buffer overrun |
| |
On Tue, Dec 2, 2008 at 8:17 PM, Andrew Morton <akpm@linux-foundation.org> wrote: > On Sat, 29 Nov 2008 17:50:39 +0530 > Balbir Singh <balbir@linux.vnet.ibm.com> wrote: > >> * Pekka Enberg <penberg@cs.helsinki.fi> [2008-11-29 12:21:46]: >> >> > Hi Balbir, >> > >> > On Sat, Nov 29, 2008 at 12:08 PM, Balbir Singh >> > <balbir@linux.vnet.ibm.com> wrote: >> > > mconsole_init() passed 256 bytes as length in os_create_unix_socket, while >> > > the sizeof UNIX_PATH_MAX is 108. This patch fixes that problem and avoids >> > > a big overrun bug reported on UML bootup. >> > >> > Maybe mention that ->sun_path in struct sockaddr_un is UNIX_PATH_MAX >> > long which causes the problem? >> > >> >> Yes, the changelog can definitely add that to the changelog, I'll >> resend the patch if Jeff asks for it. > > Jeff's been quiet lately - I'll merge this one.
Yes, indeed.
> > I also tagged it for -stable, subject to Jeff's OK. I'm wondering why > this wasn't observed in earlier kernels?
Maybe because mconsole is not often used for uml? :)
| |