lkml.org 
[lkml]   [2008]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [trivial] fix missing space in printk
Ingo Molnar wrote:
> * Michael Tokarev <mjt@tls.msk.ru> wrote:
>
>> Just come across this when booting on an old hw.. Looks somewhat ugly,
>> that single missing space ;)
>>
>> And oh,
>>
>> Signed-Off-By: Michael Tokarev <mjt@tls.msk.ru>
>>
>> ;)
>
> applied to tip/x86/cleanups.
>
>> --- a/arch/x86/kernel/smpboot.c 2008-10-10 02:13:53.000000000 +0400
>> +++ b/arch/x86/kernel/smpboot.c 2008-12-05 14:39:29.608353301 +0300
>> @@ -1084,7 +1084,7 @@ static int __init smp_sanity_check(unsig
>> #endif
>>
>> if (!physid_isset(hard_smp_processor_id(), phys_cpu_present_map)) {
>> - printk(KERN_WARNING "weird, boot CPU (#%d) not listed"
>> + printk(KERN_WARNING "weird, boot CPU (#%d) not listed "
>> "by the BIOS.\n", hard_smp_processor_id());
>
> btw., the reason for that bug was the incorrect line break in the middle
> of a string - we humans just dont notice a missing space in that context.
>
> So in the final commit i've moved the string to a single line, see it
> attached below.

Oh well. Thanks. There's another very similar thing in
arch/x86/kernel/pci-dma.c, via_no_dac() (attached).

By the way, where such tiny/trivial things should go?

Thanks!

/mjt
--- a/arch/x86/kernel/pci-dma.c 2008-10-10 02:13:53 +0400
+++ b/arch/x86/kernel/pci-dma.c 2008-12-05 15:45:56 +0300
@@ -409,8 +409,8 @@ fs_initcall(pci_iommu_init);
static __devinit void via_no_dac(struct pci_dev *dev)
{
if ((dev->class >> 8) == PCI_CLASS_BRIDGE_PCI && forbid_dac == 0) {
- printk(KERN_INFO "PCI: VIA PCI bridge detected."
- "Disabling DAC.\n");
+ printk(KERN_INFO
+ "PCI: VIA PCI bridge detected. Disabling DAC.\n");
forbid_dac = 1;
}
}
\
 
 \ /
  Last update: 2008-12-05 13:49    [W:0.053 / U:0.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site