Messages in this thread | | | Date | Fri, 5 Dec 2008 14:13:12 +1100 | From | Nick Andrew <> | Subject | Re: [PATCH] Use vprintk rather that vsnprintf where possible |
| |
On Fri, Dec 05, 2008 at 04:05:06AM +0100, Kay Sievers wrote: > On Thu, Dec 4, 2008 at 21:41, Matt Mackall <mpm@selenic.com> wrote: > > This does away with lots of large static and on-stack buffers as well > > as a few associated locks. > > > - len = snprintf(s, 256, KERN_DEBUG "%s: ", prefix); > > - > > va_start(args, fmt); > > - len += vsnprintf(&s[len], (256 - len), fmt, args); > > + printk(KERN_DEBUG "%s: ", prefix); > > + vprintk(fmt, args); > > If we convert to two printk calls for a single line, does that not > possibly get mixed up with printks from other locations and lead to > hardly readable log output?
That's right.
Nick.
| |