Messages in this thread |  | | | Date | Fri, 5 Dec 2008 04:05:06 +0100 | | From | "Kay Sievers" <> | | Subject | Re: [PATCH] Use vprintk rather that vsnprintf where possible |
| |
On Thu, Dec 4, 2008 at 21:41, Matt Mackall <mpm@selenic.com> wrote: > This does away with lots of large static and on-stack buffers as well > as a few associated locks.
> - len = snprintf(s, 256, KERN_DEBUG "%s: ", prefix); > - > va_start(args, fmt); > - len += vsnprintf(&s[len], (256 - len), fmt, args); > + printk(KERN_DEBUG "%s: ", prefix); > + vprintk(fmt, args);
If we convert to two printk calls for a single line, does that not possibly get mixed up with printks from other locations and lead to hardly readable log output?
Thanks, Kay
|  |