lkml.org 
[lkml]   [2008]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch 101/104] ext3: dont try to resize if there are no reserved gdt blocks left
    From
    Date
    On Wed, 03 Dec 2008 11:56:53 PST, Greg KH said:

    > if (reserved_gdb || gdb_off == 0) {
    > if (!EXT3_HAS_COMPAT_FEATURE(sb,
    > - EXT3_FEATURE_COMPAT_RESIZE_INODE))
    {
    > + EXT3_FEATURE_COMPAT_RESIZE_INODE)
    > + || !le16_to_cpu(es->s_reserved_gdt_blocks)) {
    > ext3_warning(sb, __func__,
    > "No reserved GDT blocks, can't resize");
    > return -EPERM;

    What's the codepath if the compat_feature part trips, but the le16_to_cpu
    doesn't? Looks to me like it will then skip over the 'return -EPERM'?
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2008-12-04 23:13    [W:4.225 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site