lkml.org 
[lkml]   [2008]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From"Rafael J. Wysocki" <>
SubjectRe: Regression from 2.6.26: Hibernation (possibly suspend) broken on Toshiba R500 (bisected)
DateThu, 4 Dec 2008 23:01:26 +0100
On Thursday, 4 of December 2008, Linus Torvalds wrote:
>
> On Thu, 4 Dec 2008, Rafael J. Wysocki wrote:
> >
> > Well, in principle it may be related to the way we handle bridges during
> > resume
>
> Ahh. Yes, that's possible. It's quite possible that the problem isn't
> resource allocation per se, but just the bigger complexity at resume time.
>
> This is a hibernate-only issue for you, right? Or is it about regular
> suspend-to-ram too?

It is suspend to RAM too, from what I can tell.

> > but I really need to read some docs and compare them with the code
> > before I can say anything more about that. Surely, nothing like this
> > issue has ever been reported before.
>
> Well, how stable has hibernate been on that particular machine
> historically?
>
> Because the half-revert alignment patch (ie reverting part of 5f17cf) that
> made it work for you would actually have been a non-issue in the original
> code that was pre-PCI-resource-alignment cleanup (commit 88452565).
>
> So the patch you partially reverted was literally the one that made the
> Cardbus allocation work the _same_ way as it did historically, before
> 88452565. So if the new code breaks for you, then so should the "old" code
> (ie 2.6.25 and earlier).
>
> So the "hasn't been reported before" case may well be just another way of
> saying "hibernate has never been very reliable".

This is a new box and the kernels earlier than 2.6.27-rc3 have not been tested
on it. So, in fact, it's quite possible that hibernation would fail on it with
earlier kernels as well.

Thanks,
Rafael


\
 
 \ /
  Last update: 2008-12-04 23:13    [from the cache]
©2003-2010