Messages in this thread | | | Date | Fri, 5 Dec 2008 00:17:52 +1100 | From | Nick Andrew <> | Subject | Re: [PATCH] trivial: printk: fix indentation of new_text_line declaration |
| |
On Thu, Dec 04, 2008 at 12:44:34PM +0100, Jiri Kosina wrote: > I have just come across bogus indentation of new_text_line declaration. I > have applied the patch below to trivial tree. If the indentation had some > specific non-obvious purpose and was done intentionally this way, please > let me know :)
That's cool. Ingo tweaked my patch and moved the static declaration outside the function and mistakenly left the indent in place.
I'm actually not too happy about new_text_line being a static; I may well submit a patch to fix that. But in the meantime, fixing the indent is fine.
> From: Jiri Kosina <jkosina@suse.cz> > Subject: trivial: printk: fix indentation of new_text_line declaration > > Remove bogus indentation of new_text_line declaration introduced in > commit ac60ad741. > > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Acked-by: Nick Andrew <nick@nick-andrew.net>
Nick.
| |