Messages in this thread | | | Date | Thu, 4 Dec 2008 13:48:45 +0100 | From | Cornelia Huck <> | Subject | Re: [PATCH] DEBUG_KOBJECT vs. DYNAMIC_PRINTK_DEBUG |
| |
On Wed, 3 Dec 2008 15:12:03 -0500, Jason Baron <jbaron@redhat.com> wrote:
> indeed. you raise the more general question of what do if both 'DEBUG' > and 'CONFIG_DYNAMIC_PRINTK_DEBUG' are set for a file? I think that in > general the 'DEBUG' should take precedence, as you point out. However, I > think we should fix this by reshuffling the logic in > include/linux/kernel.h by doing: > > if (DEBUG) > #define pr_debug printk > elseif (CONFIG_DYNAMIC_PRINTK_DEBUG) > #define pr_debug dynamic_pr_debug() > else > #define pr_debug if (0) blah: > endif > > make sense? what do you think?
Yes, that makes sense, I agree. I'll follow up with a patch.
| |