lkml.org 
[lkml]   [2008]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] DEBUG_KOBJECT vs. DYNAMIC_PRINTK_DEBUG
On Wed, 3 Dec 2008 15:12:03 -0500,
Jason Baron <jbaron@redhat.com> wrote:

> indeed. you raise the more general question of what do if both 'DEBUG'
> and 'CONFIG_DYNAMIC_PRINTK_DEBUG' are set for a file? I think that in
> general the 'DEBUG' should take precedence, as you point out. However, I
> think we should fix this by reshuffling the logic in
> include/linux/kernel.h by doing:
>
> if (DEBUG)
> #define pr_debug printk
> elseif (CONFIG_DYNAMIC_PRINTK_DEBUG)
> #define pr_debug dynamic_pr_debug()
> else
> #define pr_debug if (0) blah:
> endif
>
> make sense? what do you think?

Yes, that makes sense, I agree. I'll follow up with a patch.


\
 
 \ /
  Last update: 2008-12-04 13:51    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site