lkml.org 
[lkml]   [2008]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Experimental][PATCH 21/21]memcg-new-hierarchical-reclaim.patch
From
Daisuke Nishimura said:
> On Wed, 3 Dec 2008 14:14:23 +0900, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>> Implement hierarchy reclaim by cgroup_id.

>> + rcu_read_lock();
>> + if (!root_mem->use_hierarchy) {
>> + spin_lock(&root_mem->reclaim_param_lock);
>> + root_mem->scan_age++;
>> + spin_unlock(&root_mem->reclaim_param_lock);
>> + css_get(&root_mem->css);
>> + goto out;
>> }
>>
> I think you forgot "ret = root_mem".
> I got NULL pointer dereference BUG in my test(I've not tested
> use_hierarchy case yet).
>
yes...thank you for catching. will fix.

-Kame



\
 
 \ /
  Last update: 2008-12-04 13:47    [W:0.102 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site