Messages in this thread | | | Date | Thu, 4 Dec 2008 21:44:52 +0900 (JST) | Subject | Re: [Experimental][PATCH 21/21]memcg-new-hierarchical-reclaim.patch | From | "KAMEZAWA Hiroyuki" <> |
| |
Daisuke Nishimura said: > On Wed, 3 Dec 2008 14:14:23 +0900, KAMEZAWA Hiroyuki > <kamezawa.hiroyu@jp.fujitsu.com> wrote: >> Implement hierarchy reclaim by cgroup_id.
>> + rcu_read_lock(); >> + if (!root_mem->use_hierarchy) { >> + spin_lock(&root_mem->reclaim_param_lock); >> + root_mem->scan_age++; >> + spin_unlock(&root_mem->reclaim_param_lock); >> + css_get(&root_mem->css); >> + goto out; >> } >> > I think you forgot "ret = root_mem". > I got NULL pointer dereference BUG in my test(I've not tested > use_hierarchy case yet). > yes...thank you for catching. will fix.
-Kame
| |