Messages in this thread | | | Subject | Re: [PATCH 0/2] pdflush fix and enhancement | From | Andi Kleen <> | Date | Wed, 31 Dec 2008 01:28:46 +0100 |
| |
Peter W Morreale <pmorreale@novell.com> writes:
> The following series implements a fix for pdflush thread creation and an > enhancement for allowing the setting of the minimum and maximun number > of pdflush threads.
You forgot to state why the admin should control that?
Each sysctl essentially presents a failure of the automatic tuning algorithms of the kernel (kernel hackers admitting defeat).
So a patch adding new ones at least needs a clear rationale what problem it is trying to fix and why the automatic tuning cannot be fixed instead to address this case without new knobs.
-Andi
-- ak@linux.intel.com
| |