lkml.org 
[lkml]   [2008]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] include/linux: Move definitions from usb.h to usb/ch9.h
    On Mon, Dec 29, 2008 at 10:48:19PM +0100, Julia Lawall wrote:
    > From: Julia Lawall <julia@diku.dk>
    >
    > The functions:
    >
    > usb_endpoint_dir_in(epd)
    > usb_endpoint_dir_out(epd)
    > usb_endpoint_is_bulk_in(epd)
    > usb_endpoint_is_bulk_out(epd)
    > usb_endpoint_is_int_in(epd)
    > usb_endpoint_is_int_out(epd)
    > usb_endpoint_is_isoc_in(epd)
    > usb_endpoint_is_isoc_out(epd)
    > usb_endpoint_num(epd)
    > usb_endpoint_type(epd)
    > usb_endpoint_xfer_bulk(epd)
    > usb_endpoint_xfer_control(epd)
    > usb_endpoint_xfer_int(epd)
    > usb_endpoint_xfer_isoc(epd)
    >
    > are moved from include/linux/usb.h to include/linux/usb/ch9.h.
    > include/linux/usb/ch9.h makes more sense for these functions because they
    > only depend on constants that are defined in this file.

    I thought the include/linux/usb/ch9.h was supposed to include values that are
    defined in various USB specifications (starting with the protocol "chapter 9"
    from the USB 1.1 bus specification). The constants (masks) used by these
    functions aren't part of the standards, so why move these functions to
    include/linux/usb/ch9.h? Was it confusing to find these functions, or do you
    have an overall plan for these changes?

    Sarah Sharp


    \
     
     \ /
      Last update: 2008-12-31 00:41    [W:0.019 / U:60.764 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site