Messages in this thread | | | Date | Tue, 30 Dec 2008 19:18:23 +0100 | From | Helge Deller <> | Subject | Re: [PATCH 1/2] module.c: fix module loading failure of large modules (take 2) |
| |
Kyle McMartin wrote: > Ugh, I fail at typing, resending for rusty's benefit. > > On Tue, Dec 30, 2008 at 01:07:24PM -0500, Kyle McMartin wrote: >> [Adding rusty to CC] >> >> On Mon, Dec 29, 2008 at 09:43:12PM +0100, Helge Deller wrote: >>> +unsigned long module_additional_section_size(struct module *mod, >>> + unsigned int section); >>> + >> I think this would be more palatable as >> >> #ifdef HAVE_MODULE_SECTION_STUBS >> unsigned long module_additional_section_size(struct module *mod, >> unsigned int section); >> #else >> static inline unsigned long module_additional_section_size(struct module *mod, >> unsigned int section) >> { >> return 0; >> } >> #endif >> >> and removing the conditional in kernel/module.c, possibly the symbol >> should be "arch_module_a..." just to make it clear to anyone reading. >> >> Anyway, it's up to rusty. >> >> Rusty, we'd like to get this patch in, so I can merge the dependent >> parisc-specific patch.
Rusty, I think I've a cleaner patch for that and will send it soon...
Helge
| |