lkml.org 
[lkml]   [2008]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] tracing/function-graph-tracer: improve duration output
    2008/12/3 Ingo Molnar <mingo@elte.hu>:
    > small detail: i'd suggest to remove the newline before the context-switch
    > box. That makes it appear visually to attach logically with the
    > switch-out place, not the switch-in place:
    >
    >> 0) cat-2796 | 0.579 us | native_load_sp0();
    >> 0) cat-2796 | 0.722 us | native_load_tls();
    >> ------------------------------------------
    >> | 0) cat-2796 => events/-9
    >> ------------------------------------------
    >>
    >> 0) events/-9 | | finish_task_switch() {
    >> 0) events/-9 | 0.789 us | _spin_unlock_irq();
    >> 0) events/-9 | 2.309 us | }
    >> 0) events/-9 | ! 269848.5 us | }
    >
    > which is what we want to express.
    >


    Ok, I'll fix it.


    >
    > btw., i tested the graph tracer on a 16-way 64-bit box as well, and the
    > multi-digit CPU field printout magic works fine there too:
    >
    > 9) | pick_next_task() {
    > 9) 0.283 us | pick_next_task_fair();
    > 9) 0.276 us | pick_next_task_rt();
    > 9) 0.273 us | pick_next_task_fair();
    > 9) 0.279 us | pick_next_task_idle();
    > 9) 2.596 us | }
    > 9) 0.566 us | __lock_text_start();
    > 10) 0.299 us | }
    > 10) | mm_init() {
    > 10) | pgd_alloc() {
    > 10) | __get_free_pages() {
    > 10) | alloc_pages_current() {
    > 10) 0.330 us | policy_zonelist();
    > 10) | __alloc_pages_internal() {
    >
    > Ingo
    >

    Hmm not really, there should be one space more before the 9 to fit the
    log10(MAX_CPU) here and not break
    the column.

    Thanks!


    \
     
     \ /
      Last update: 2008-12-03 11:09    [W:0.024 / U:0.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site