Messages in this thread | | | Date | Wed, 3 Dec 2008 16:11:56 -0500 (EST) | From | Steven Rostedt <> | Subject | Re: [PATCH 1/3] ftrace: graph of a single function |
| |
On Wed, 3 Dec 2008, Andrew Morton wrote:
> On Wed, 03 Dec 2008 15:36:57 -0500 > Steven Rostedt <rostedt@goodmis.org> wrote: > > > +static struct seq_operations ftrace_graph_seq_ops = { > > + .start = g_start, > > + .next = g_next, > > + .stop = g_stop, > > + .show = g_show, > > +}; > > This could be static I think.
s/static/const/
Damn damn damn damn!!!! I said to myself, I need to add const there and still forgot :-(
> > It's probably not worth even commenting on or fixing this sort > of thing. Just rely on someone(tm) doing periodic sweeps to > fix them all up.
Still on my todo list for kernel/trace/*.c
-- Steve
| |