lkml.org 
[lkml]   [2008]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] ftrace: graph of a single function

On Wed, 3 Dec 2008, Andrew Morton wrote:

> On Wed, 03 Dec 2008 15:36:57 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > +static struct seq_operations ftrace_graph_seq_ops = {
> > + .start = g_start,
> > + .next = g_next,
> > + .stop = g_stop,
> > + .show = g_show,
> > +};
>
> This could be static I think.

s/static/const/

Damn damn damn damn!!!! I said to myself, I need to add const there and
still forgot :-(

>
> It's probably not worth even commenting on or fixing this sort
> of thing. Just rely on someone(tm) doing periodic sweeps to
> fix them all up.

Still on my todo list for kernel/trace/*.c

-- Steve



\
 
 \ /
  Last update: 2008-12-03 22:15    [W:0.142 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site