lkml.org 
[lkml]   [2008]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] DEBUG_KOBJECT vs. DYNAMIC_PRINTK_DEBUG
    On Tue, Dec 02, 2008 at 02:52:51PM +0100, Cornelia Huck wrote:
    > DEBUG_KOBJECT has no effect when DYNAMIC_PRINTK_DEBUG is set
    > (and you can get the messages via that feature), so let's make
    > it depend on !DYNAMIC_PRINTK_DEBUG.
    >

    indeed. you raise the more general question of what do if both 'DEBUG'
    and 'CONFIG_DYNAMIC_PRINTK_DEBUG' are set for a file? I think that in
    general the 'DEBUG' should take precedence, as you point out. However, I
    think we should fix this by reshuffling the logic in
    include/linux/kernel.h by doing:

    if (DEBUG)
    #define pr_debug printk
    elseif (CONFIG_DYNAMIC_PRINTK_DEBUG)
    #define pr_debug dynamic_pr_debug()
    else
    #define pr_debug if (0) blah:
    endif

    make sense? what do you think?

    thanks,

    -Jason


    \
     
     \ /
      Last update: 2008-12-03 21:41    [W:0.021 / U:92.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site