[lkml]   [2008]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[patch 096/104] ext4: calculate journal credits correctly
    2.6.27-stable review patch.  If anyone has any objections, please let us know.

    From: "Theodore Ts'o" <>

    (cherry picked from commit ac51d83705c2a38c71f39cde99708b14e6212a60)

    This fixes a 2.6.27 regression which was introduced in commit a02908f1.

    We weren't passing the chunk parameter down to the two subections,
    ext4_indirect_trans_blocks() and ext4_ext_index_trans_blocks(), with
    the result that massively overestimate the amount of credits needed by
    ext4_da_writepages, especially in the non-extents case. This causes
    failures especially on /boot partitions, which tend to be small and
    non-extent using since GRUB doesn't handle extents.

    This patch fixes the bug reported by Joseph Fannin at:

    Signed-off-by: "Theodore Ts'o" <>
    Signed-off-by: Greg Kroah-Hartman <>

    fs/ext4/inode.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/fs/ext4/inode.c
    +++ b/fs/ext4/inode.c
    @@ -4444,9 +4444,10 @@ static int ext4_indirect_trans_blocks(st
    static int ext4_index_trans_blocks(struct inode *inode, int nrblocks, int chunk)
    if (!(EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL))
    - return ext4_indirect_trans_blocks(inode, nrblocks, 0);
    - return ext4_ext_index_trans_blocks(inode, nrblocks, 0);
    + return ext4_indirect_trans_blocks(inode, nrblocks, chunk);
    + return ext4_ext_index_trans_blocks(inode, nrblocks, chunk);
    * Account for index blocks, block groups bitmaps and block group
    * descriptor blocks if modify datablocks and index blocks

     \ /
      Last update: 2008-12-03 21:31    [W:0.022 / U:5.492 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site