lkml.org 
[lkml]   [2008]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 001/104] USB: gadget rndis: send notifications
    2.6.27-stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Richard Röjfors <richard.rojfors@endian.se>

    commit ff3495052af48f7a2bf7961b131dc9e161dae19c upstream.

    It turns out that atomic_inc_return() returns the *new* value
    not the original one, so the logic in rndis_response_available()
    kept the first RNDIS response notification from getting out.
    This prevented interoperation with MS-Windows (but not Linux).

    Fix this to make RNDIS behave again.

    Signed-off-by: Richard Röjfors <richard.rojfors@endian.se>
    Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/usb/gadget/f_rndis.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/gadget/f_rndis.c
    +++ b/drivers/usb/gadget/f_rndis.c
    @@ -303,7 +303,7 @@ static void rndis_response_available(voi
    __le32 *data = req->buf;
    int status;

    - if (atomic_inc_return(&rndis->notify_count))
    + if (atomic_inc_return(&rndis->notify_count) != 1)
    return;

    /* Send RNDIS RESPONSE_AVAILABLE notification; a
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-12-03 20:53    [W:0.020 / U:29.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site