Messages in this thread | | | Date | Wed, 03 Dec 2008 16:17:52 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH 1/1] Char: n_tty, include module.h |
| |
On 12/03/2008 01:43 PM, Alan Cox wrote: > On Wed, 3 Dec 2008 13:28:58 +0100 > Jiri Slaby <jirislaby@gmail.com> wrote: > >> Since we are using EXPORT_SYMBOL, we should include linux/module.h >> >> Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > > NAK > > n_tty doesn't use EXPORT_SYMBOL.
Sure it does. Maybe the patch didn't come to you yet. Will repost to akpm as a ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix.
$ grep EXPORT drivers/char/n_tty.c EXPORT_SYMBOL_GPL(n_tty_flush_buffer); EXPORT_SYMBOL_GPL(n_tty_chars_in_buffer); EXPORT_SYMBOL_GPL(n_tty_write_wakeup); EXPORT_SYMBOL_GPL(n_tty_receive_buf); EXPORT_SYMBOL_GPL(n_tty_set_termios); EXPORT_SYMBOL_GPL(n_tty_close); EXPORT_SYMBOL_GPL(n_tty_open); EXPORT_SYMBOL_GPL(n_tty_read); EXPORT_SYMBOL_GPL(n_tty_write); EXPORT_SYMBOL_GPL(n_tty_poll);
| |