lkml.org 
[lkml]   [2008]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ext3, ext4: do_split() fix loop, with obvious unsigned wrap
Bill Davidsen wrote:
> I seriously disagree on that, writing it as a for makes it totally
> clear that the index initialization is part of the loop.
> I know, looks funny, not the way we have always done it, not invented
> here...
>
Just to be clear, I didn't mean that in any bad way, just that sometimes
a new format, even if correct and unambiguous, looks strange to the eye
and is not used just because it jars. I still think putting
initialization for a loop in the start of the for is defensive
programming, perhaps I've had too many bumblers inherit my code.

--
Bill Davidsen <davidsen@tmr.com>
"Woe unto the statesman who makes war without a reason that will still
be valid when the war is over..." Otto von Bismark




\
 
 \ /
  Last update: 2008-12-03 15:29    [W:0.060 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site