lkml.org 
[lkml]   [2008]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] x86: reboot.c declare port_cf9_safe before they get used
    Date
    On Monday, December 29, 2008 3:08 am Ingo Molnar wrote:
    > * Jaswinder Singh Rajput <jaswinder@infradead.org> wrote:
    > > Hello Ingo,
    > >
    > > On Sat, 2008-12-27 at 11:31 +0100, Ingo Molnar wrote:
    > > > btw., this is ugly now:
    > > > > --- a/arch/x86/kernel/reboot.c
    > > > > +++ b/arch/x86/kernel/reboot.c
    > > > > @@ -22,6 +22,7 @@
    > > > > #endif
    > > > >
    > > > > #include <mach_ipi.h>
    > > > > +#include "../pci/pci.h"
    > > >
    > > > could you send another patch that moves arch/x86/pci/pci.h to
    > > > arch/x86/include/asm/pci_x86.h (and update all the pci.h include
    > > > sites)?
    > >
    > > 1. I send [PATCH] move arch/x86/pci/pci.h to
    > > arch/x86/include/asm/pci_x86.h but I forget to write x86: before this
    > > patch.
    >
    > no, your patch is fine. I routinely fix up commit logs.
    >
    > Jesse, is it fine to you if we push this via the x86 tree? A couple of
    > usage sites of arch/x86/pci/pci.h arose that use ../pci/pci.h kind of ugly
    > #include prefixes, which justifies moving the file to
    > arch/x86/include/asm. No change in behavior.

    Yeah, that's fine. Best to get it over with... I'll take care of any
    conflicts in my tree when I prepare my merge.

    Thanks,
    --
    Jesse Barnes, Intel Open Source Technology Center

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-12-29 18:13    [W:0.022 / U:0.744 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site