Messages in this thread |  | | | Date | Sat, 27 Dec 2008 20:24:30 +0100 | | From | Sam Ravnborg <> | | Subject | Re: [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace |
| |
On Sat, Dec 27, 2008 at 11:15:01AM -0800, H. Peter Anvin wrote: > Sam Ravnborg wrote: > > On Sat, Dec 27, 2008 at 10:58:11AM -0800, H. Peter Anvin wrote: > >> Sam Ravnborg wrote: > >>> I wnet with the scripted conversion for now. > >>> If that does not fly we can come back to this proposal. > >>> > >>> What I like most with the auto conversion is that we avoid > >>> adding yet another special rule about how to do stuff in exported headers. > >>> > >> Indeed, and being keyword conversion, it's independent of context, at > >> least as long as one doesn't have too many run-ins with weird uses of > >> the # and ## preprocessor operators, which are a *lot* easier to rule > >> out globally. > > > > Speaking of what we want to use in exported headers. > > What is the recommendation with respect to uint32_t and friends? > > To my best knowledge they are banned in exported headers as they > > are not part of the kernel namespace and I see few users too. > > But is this something we should check for? > > I personally would not be upset if we auto-changed {su}{8,16,32,64}, > [u]int_{8,16,32,64}_t and bool into the appropriate __{su}{8,16,32,64} > types and _Bool. I think the upside is way bigger than the potential > downside.
I was only thinking of a warning so we could have this part cleaned up. It is for the most part a trivial task to do for a volunteer.
I could also see some sporadic use of u_int32_t - dunno where it comes from. But looks wrong to me.
Sam
|  |