lkml.org 
[lkml]   [2008]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 0 of 9] swiotlb: use phys_addr_t for pages
From
On Sat, 27 Dec 2008 11:48:23 +0100
Ingo Molnar <mingo@elte.hu> wrote:

> Also, this patch will interact with ia64 materially:
>
> Subject: [PATCH 9 of 9] ia64/x86/swiotlb: use enum dma_data_direciton in dma_ops
>
> So we'll need a bit more confidence in the testing status of this queue,
> and we probably want to wait until Tony merged the pending .29 ia64
> changes, and also get an Ack from Tony for these bits:
>
> arch/ia64/dig/dig_vtd_iommu.c | 9 +++--
> arch/ia64/hp/common/hwsw_iommu.c | 22 ++++++++------
> arch/ia64/hp/common/sba_iommu.c | 12 ++++---
> arch/ia64/include/asm/dma-mapping.h | 29 +++++++++---------
> arch/ia64/include/asm/swiotlb.h | 26 ++++++++++------
> arch/ia64/kernel/machvec.c | 6 ++-
> arch/ia64/sn/kernel/io_common.c | 3 +-
> arch/ia64/sn/pci/pci_dma.c | 21 ++++++++-----
> arch/ia64/sn/pci/pcibr/pcibr_dma.c | 3 +-
> arch/ia64/sn/pci/tioca_provider.c | 3 +-
>
> (Tony Cc:-ed)

BTW, the above patch breaks IA64 build.

It's fixable but I think that it would be better to just drop this
huge patch and add some cast in powerpc code. the types of SWIOTBL
function arguments don't need to mach to DAM_API.txt though it might
be nice if so. There are other type mismatches. If we really want to
do this cleanups, we should fix up all the mismatches.


\
 
 \ /
  Last update: 2008-12-27 17:47    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site