Messages in this thread Patch in this message | | | Date | Fri, 26 Dec 2008 17:38:55 +0000 | From | Américo Wang <> | Subject | [Patch] fs/exec.c: make do_coredump() void |
| |
No one cares do_coredump()'s return value, and also it seems that it is also not necessary. So make it void.
Signed-off-by: WANG Cong <wangcong@zeuux.org> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
--- diff --git a/fs/exec.c b/fs/exec.c index ec5df9a..c48a040 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -1708,7 +1708,7 @@ int get_dumpable(struct mm_struct *mm) return (ret >= 2) ? 2 : ret; } -int do_coredump(long signr, int exit_code, struct pt_regs * regs) +void do_coredump(long signr, int exit_code, struct pt_regs * regs) { struct core_state core_state; char corename[CORENAME_MAX_SIZE + 1]; @@ -1845,5 +1845,5 @@ fail_unlock: current->fsuid = fsuid; coredump_finish(mm); fail: - return retval; + return; } diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h index 7394b5b..a063f7e 100644 --- a/include/linux/binfmts.h +++ b/include/linux/binfmts.h @@ -102,7 +102,7 @@ extern int setup_arg_pages(struct linux_binprm * bprm, extern int bprm_mm_init(struct linux_binprm *bprm); extern int copy_strings_kernel(int argc,char ** argv,struct linux_binprm *bprm); extern void compute_creds(struct linux_binprm *binprm); -extern int do_coredump(long signr, int exit_code, struct pt_regs * regs); +extern void do_coredump(long signr, int exit_code, struct pt_regs * regs); extern int set_binfmt(struct linux_binfmt *new); extern void free_bprm(struct linux_binprm *);
| |