lkml.org 
[lkml]   [2008]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH for -tip] irq: for_each_irq_desc() makes simplify
    [KOSAKI Motohiro - Thu, Dec 25, 2008 at 09:41:54PM +0900]
    ...
    | Is this good idea?
    | this patch also tested on above three architecture.
    |
    |
    | ===
    | Subject: [PATCH] irq: for_each_irq_desc() makes simplify
    | Impact: cleanup
    |
    | all for_each_irq_desc() usage point have !desc check.
    | then its check can move into for_each_irq_desc() macro.
    |
    |
    | Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    | CC: Yinghai Lu <yinghai@kernel.org>
    | CC: Ingo Molnar <mingo@elte.hu>
    | ---
    | arch/x86/kernel/io_apic.c | 10 ----------
    | drivers/xen/events.c | 3 ---
    | fs/proc/stat.c | 3 ---
    | include/linux/irqnr.h | 6 ++++--
    | kernel/irq/autoprobe.c | 15 ---------------
    | kernel/irq/handle.c | 3 ---
    | kernel/irq/spurious.c | 5 -----
    | 7 files changed, 4 insertions(+), 41 deletions(-)
    ...

    Hi Kosaki,

    the idea is that good indeed but I wonder if it possible
    to explain that we skip empty 'desk' in for_each_... name
    itself. Maybe for_each_irq_desc_defined :) Or something
    more convenient word instead of "defined"?

    - Cyrill -


    \
     
     \ /
      Last update: 2008-12-25 14:21    [W:0.024 / U:0.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site