lkml.org 
[lkml]   [2008]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 3/3] drivers/staging/rt2860,rt2870: Correct use of ! and &
    From: Julia Lawall <julia@diku.dk>

    IW_ENCODE_MODE is 0xF000 and thus !erq->flags & IW_ENCODE_MODE is always 0.
    I assume that !(erq->flags & IW_ENCODE_MODE) was intended.

    The semantic patch that makes this change is as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    // <smpl>
    @@ expression E; constant C; @@
    (
    !E & !C
    |
    - !E & C
    + !(E & C)
    )
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---
    drivers/staging/rt2860/sta_ioctl.c | 2 +-
    drivers/staging/rt2870/sta_ioctl.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff -u -p a/drivers/staging/rt2860/sta_ioctl.c b/drivers/staging/rt2860/sta_ioctl.c
    --- a/drivers/staging/rt2860/sta_ioctl.c
    +++ b/drivers/staging/rt2860/sta_ioctl.c
    @@ -1756,7 +1756,7 @@ int rt_ioctl_siwencode(struct net_device
    }
    else
    /* Don't complain if only change the mode */
    - if(!erq->flags & IW_ENCODE_MODE) {
    + if (!(erq->flags & IW_ENCODE_MODE)) {
    return -EINVAL;
    }
    }
    diff -u -p a/drivers/staging/rt2870/sta_ioctl.c b/drivers/staging/rt2870/sta_ioctl.c
    --- a/drivers/staging/rt2870/sta_ioctl.c
    +++ b/drivers/staging/rt2870/sta_ioctl.c
    @@ -1776,7 +1776,7 @@ int rt_ioctl_siwencode(struct net_device
    }
    else
    /* Don't complain if only change the mode */
    - if(!erq->flags & IW_ENCODE_MODE) {
    + if (!(erq->flags & IW_ENCODE_MODE)) {
    return -EINVAL;
    }
    }

    \
     
     \ /
      Last update: 2008-12-24 16:27    [W:0.028 / U:30.504 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site