Messages in this thread | | | Date | Wed, 24 Dec 2008 10:15:46 -0500 (EST) | From | Steven Rostedt <> | Subject | Re: [PATCH v2] tracing/ftrace: don't trace on early stage of a secondary cpu boot |
| |
Cool, so the CFLAGS_REMOVE solution worked.
I'm the last one to criticize someones language, especially when it is not their native tongue. The closest language outside of English that I know is German, and I would do horrible if I had to write this in German. Heck, my English sucks too ;-)
But since this is going to be a public record of what you changed, it should be a bit more clear.
On Wed, 24 Dec 2008, Frederic Weisbecker wrote:
> Impact: fix a crash/hard-reboot while enabling cpu on runtime > > On some archs, the boot of a secondary cpu can have an early fragile state. > On x86-64, the pda is not initialized on the first stage of a cpu boot but
s/on the first/in the first/
> it is needed to get the cpu number and the current task pointer. These datas
s/These datas are/This data is/
> are needed during tracing. As they were dereferenced at this stage, we got a > crash while turning on a cpu on runtime while tracing.
"we got a crash while tracing a cpu being enabled at runtime"
> > Some other archs like ia64 can have such kind of issue too. > > Changes on v2: > > We drop the previous solution of a per-arch called function to guess the current state
s/drop/dropped/
> of a cpu. That could make slow the tracing.
"That could slow down the tracing."
> This patch just drop the -pg flag on arch/x86/kernel/cpu/common.c where
"This patch removes the -pg flag..."
> live the low level cpu boot functions, and on start_secondary() and a helper
"where the low level cpu boot functions exist"
s/, and on/, on/
> function used at this stage. > > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Again, I'm still impressed by your ability to communicate in a language other than your own. And perhaps my corrections are incorrect too ;-)
Acked-by: Steven Rostedt <srostedt@redhat.com>
-- Steve
| |