lkml.org 
[lkml]   [2008]   [Dec]   [24]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 24 Dec 2008 18:04:33 +0300
FromSergei Shtylyov <>
SubjectRe: [PATCH] musb: fix DaVinci build again
Hello, I wrote:

>>>>> The last Kevin Hilman's patch seems to have been broken on its way 
>>>>> to Greg's
>>>>> tree and also probably clashed with yet another patch. Fix DaVinci 
>>>>> build again.
>>>>> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>>>>> ---
>>>>> Felipe, I have to ask you again to be more careful with patches...

>>>>    11 days have passed since this has benn sent out and I'm still 
>>>> not seeing this 2.6.28 *hot* fix in the MUSB git tree. Greg, could 
>>>> you queue this urgently, bypassing the MUSB tree?

>>>   I'll be happy if it gets combined with the following patch in your 
>>> tree:

>>> http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/usb/usb-musb-build-fixes-for-davinci.patch 

>>> fallout of which I'm fixing. Though it would've been better yet if 
>>> you just dropped that totally broken patch. I could've send a 
>>> replacment then...

>>   The patch I liked to above fixes nothing and only adds more 
>> breakage. Compare it with the original Kevin's patch:

>> http://marc.info/?l=linux-usb&m=122608723815504

>   I'm seeing Felipe returning to the list but still ignoring this thread 
> so far.
>   For how much longer we'll have to wait for this issue to be resolved? 
> 2.6.28 is 2 days away (at most).
>   Greg, what's the problem with dropping obviously broken patch?

    Greg, looks like that *2.6.28* (acyually even 2.6.27) patch is even in the 
wrong sub-series (past-2.6.28) of your tree, so there was no hope on the 
timely resolution from the very start... sigh. :-(

WBR, Sergei


\
 
 \ /
  Last update: 2008-12-24 16:07    [from the cache]
©2003-2008