lkml.org 
[lkml]   [2008]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ftrace: enable format arguments checking

    On Wed, 24 Dec 2008, Lai Jiangshan wrote:

    > Lai Jiangshan wrote:
    > > format arguments checking for ftrace_printk() is __printf(1, 2),
    > > not __printf(1, 0).
    > >
    > > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
    > > ---
    > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
    > > index 9c5bc6b..0c71788 100644
    > > --- a/include/linux/ftrace.h
    > > +++ b/include/linux/ftrace.h
    > > @@ -210,7 +210,7 @@ extern void ftrace_dump(void);
    > > static inline void
    > > ftrace_special(unsigned long arg1, unsigned long arg2, unsigned long arg3) { }
    > > static inline int
    > > -ftrace_printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 0)));
    >
    > Hi, Steven Rostedt
    > Did you notice this patch?
    > This patch changed a char in a line: s/0/2/. It enables the format checking.
    >
    > Lai.
    >
    > > +ftrace_printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 2)));
    > >
    > > static inline int
    > > ftrace_printk(const char *fmt, ...)
    > >

    Ah yes, sorry, I'm rushing to get some other things done because I'll be
    on holiday tomorrow through to Jan 5th.

    I'll pull it into the rest of my next series.

    -- Steve



    \
     
     \ /
      Last update: 2008-12-24 04:39    [W:0.022 / U:0.612 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site