lkml.org 
[lkml]   [2008]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: traps.c replace #if CONFIG_X86_32 with #ifdef CONFIG_X86_32
On Tue, 23 Dec 2008 10:20:37 -0800
"H. Peter Anvin" <hpa@kernel.org> wrote:

> > --- a/arch/x86/kernel/traps.c
> > +++ b/arch/x86/kernel/traps.c
> > @@ -692,7 +692,7 @@ void math_error(void __user *ip)
> >
> > err = swd & ~cwd & 0x3f;
> >
> > -#if CONFIG_X86_32
> > +#ifdef CONFIG_X86_32
> > if (!err)
> > return;
> > #endif
>
> Applied to tip:x86/fpu, thanks.
>
> Andi: you might have a perspective on this: in math_error() we bail out
> if there is no error on i386, but not on x86-64. I am rather assuming
> that is because it simply can't happen on x86-64 (no IRQ 13 bullshit) so
> it wasn't necessary?
>

Some 32-bit x86 clones generate math error interrupts when there is no
actual error.


\
 
 \ /
  Last update: 2008-12-23 21:37    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site