lkml.org 
[lkml]   [2008]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 02/27] drivers/net: fix sparse warnings: make do-while a compound statement
    From
    Date
    Harvey Harrison <harvey.harrison@gmail.com> writes:

    >> There are many ways to make the code more merge friendly at a cost of
    >> readability. Hope we don't go this way.
    >
    > Linus himself added that particular warning to sparse...may want to check
    > with him the reason for it.

    Once again, this is a personal thing, and a harmless one.

    Sometimes I think using this sparse thing does more harm than good.
    Not that the tool itself is bad - I find it really useful, many sparse
    warnings actually did cause code improvement.

    It's like with knives, there are good uses and a bit less good ones.
    --
    Krzysztof Halasa


    \
     
     \ /
      Last update: 2008-12-23 18:39    [W:0.020 / U:30.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site