Messages in this thread | | | Date | Tue, 23 Dec 2008 09:29:52 -0800 | Subject | Re: [PATCH] sparc64: use unsigned long long for u64 | From | Ken Chen <> |
| |
On Tue, Dec 23, 2008 at 9:26 AM, Sam Ravnborg <sam@ravnborg.org> wrote: >> wait, why does this need to be changed? > > We have: > clocksource_tick.read = tick_ops->get_tick; > > And clocksource_tick is of type clocksource: > > struct clocksource { > ... > cycle_t (*read)(void); > > And cycle_t is: > /* clocksource cycle base type */ > typedef u64 cycle_t; > > And u64 is now: > unsigned long long - thus we need to fix prototype > of get_tick to fix the warnings. > > A cast could do it - but fixing the real problem > is better here.
Sounds good to me. It was just a question. Thank you for the explanation.
- Ken
| |