lkml.org 
[lkml]   [2008]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 11/14] kmemleak: Remove some of the kmemleak false positives
    From
    Date
    On Fri, 2008-12-19 at 22:15 +0200, Pekka Enberg wrote:
    > On Fri, Dec 19, 2008 at 8:13 PM, Catalin Marinas
    > <catalin.marinas@arm.com> wrote:
    > > There are allocations for which the main pointer cannot be found but
    > > they are not memory leaks. This patch fixes some of them. For more
    > > information on false positives, see Documentation/kmemleak.txt.
    > >
    > > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
    >
    > > @@ -2882,6 +2883,12 @@ static int __init con_init(void)
    > > */
    > > for (currcons = 0; currcons < MIN_NR_CONSOLES; currcons++) {
    > > vc_cons[currcons].d = vc = alloc_bootmem(sizeof(struct vc_data));
    > > + /*
    > > + * Kmemleak does not track the memory allocated via
    > > + * alloc_bootmem() but this block contains pointers to
    > > + * other blocks allocated via kmalloc.
    > > + */
    > > + kmemleak_alloc(vc, sizeof(struct vc_data), 1, GFP_ATOMIC);
    > > INIT_WORK(&vc_cons[currcons].SAK_work, vc_SAK);
    > > visual_init(vc, currcons, 1);
    > > vc->vc_screenbuf = (unsigned short *)alloc_bootmem(vc->vc_screenbuf_size);
    >
    > I think there was some discussion about adding hooks to the bootmem
    > allocator. Didn't that work out?

    I had a look but the combination of alloc_bootmem, reserve_bootmem and
    free_bootmem doesn't seem feasible for kmemleak since calling these
    functions doesn't always come in alloc/free pairs (unless I
    misunderstand it).

    --
    Catalin



    \
     
     \ /
      Last update: 2008-12-22 13:07    [W:0.021 / U:0.776 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site