Messages in this thread | | | Date | Tue, 23 Dec 2008 00:01:33 +0100 | From | Oleg Nesterov <> | Subject | Re: [RFC][PATCH 4/6][v3] Define siginfo_from_ancestor_ns() |
| |
On 12/22, Oleg Nesterov wrote: > > On 12/20, Sukadev Bhattiprolu wrote: > > > > + * TODO: > > + * Making SI_ASYNCIO a kernel signal could make this less hacky. > > + */ > > +#ifdef CONFIG_PID_NS > > +static inline int siginfo_from_user(siginfo_t *info) > > +{ > > + if (!is_si_special(info) && SI_FROMUSER(info) && > > OK, if we can trust SI_FROMUSER(), then it is better, i agree.
Aaah, forgot to mention...
But could you explain how are you going to fix another problem, .si_pid mangling? This was another reason for (yes, ugly, agreed) SIG_FROM_USER in .si_signo.
Oleg.
| |