lkml.org 
[lkml]   [2008]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 07/27] drivers/net/bonding: fix sparse warnings: move decls to header file
    Date
    From
    Fix this sparse warnings:

    drivers/net/bonding/bond_main.c:104:20: warning: symbol 'bonding_defaults' was not declared. Should it be static?
    drivers/net/bonding/bond_main.c:204:22: warning: symbol 'ad_select_tbl' was not declared. Should it be static?
    drivers/net/bonding/bond_sysfs.c:60:21: warning: symbol 'bonding_rwsem' was not declared. Should it be static?

    Signed-off-by: Hannes Eder <hannes@hanneseder.net>
    ---
    drivers/net/bonding/bond_main.c | 1 -
    drivers/net/bonding/bond_sysfs.c | 3 ---
    drivers/net/bonding/bonding.h | 5 +++++
    3 files changed, 5 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
    index a34c186..460c2ca 100644
    --- a/drivers/net/bonding/bond_main.c
    +++ b/drivers/net/bonding/bond_main.c
    @@ -154,7 +154,6 @@ LIST_HEAD(bond_dev_list);
    static struct proc_dir_entry *bond_proc_dir = NULL;
    #endif

    -extern struct rw_semaphore bonding_rwsem;
    static __be32 arp_target[BOND_MAX_ARP_TARGETS] = { 0, } ;
    static int arp_ip_count = 0;
    static int bond_mode = BOND_MODE_ROUNDROBIN;
    diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
    index 1860f81..18cf478 100644
    --- a/drivers/net/bonding/bond_sysfs.c
    +++ b/drivers/net/bonding/bond_sysfs.c
    @@ -43,9 +43,6 @@

    /*---------------------------- Declarations -------------------------------*/

    -extern struct bond_params bonding_defaults;
    -extern struct bond_parm_tbl ad_select_tbl[];
    -
    static int expected_refcount = -1;
    /*--------------------------- Data Structures -----------------------------*/

    diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
    index 31ae5b5..ca849d2 100644
    --- a/drivers/net/bonding/bonding.h
    +++ b/drivers/net/bonding/bonding.h
    @@ -350,6 +350,11 @@ extern const struct bond_parm_tbl bond_mode_tbl[];
    extern const struct bond_parm_tbl xmit_hashtype_tbl[];
    extern const struct bond_parm_tbl arp_validate_tbl[];
    extern const struct bond_parm_tbl fail_over_mac_tbl[];
    +extern struct bond_params bonding_defaults;
    +extern struct bond_parm_tbl ad_select_tbl[];
    +
    +/* exported from bond_sysfs.c */
    +extern struct rw_semaphore bonding_rwsem;

    #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
    void bond_send_unsolicited_na(struct bonding *bond);


    \
     
     \ /
      Last update: 2008-12-22 20:23    [W:0.022 / U:29.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site