Messages in this thread | | | Date | Mon, 22 Dec 2008 13:37:09 -0500 (EST) | From | Steven Rostedt <> | Subject | Re: [PATCH] ring_bufer: fix BUF_PAGE_SIZE |
| |
On Sun, 21 Dec 2008, Ingo Molnar wrote: > * Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> > In the old codes, these lines confuse me: > > return (addr & ~PAGE_MASK) - (PAGE_SIZE - BUF_PAGE_SIZE); > > addr &= PAGE_MASK; > > This patch mostly make the codes concordant. > > ah, okay. Steve, any strong feelings against the patch? And we might just > go for removing BUF_PAGE_SIZE itself instead.
I'll need to rename BUF_PAGE_SIZE to BUF_SIZE since it is really the size of a buffer per page. The pages will now have some header information on it to let things like splice take the page away and still be able to translate what is on the page.
-- Steve
| |