[lkml]   [2008]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 01/26] kbuild: fix -I option expansion with O=... builds
    When adding extra -I options with O=... we could
    end up in a situation where there were no parameters to -I.
    So we had a commandline that looked like this:

    ... -I -Wall ...

    This had the undesired side effect that gcc assumed "-Wall"
    was a path to look for include files so this options was
    effectively ignored.

    This happens only when we build the generated module.mod.c files
    as part of the final modules builds and is as such harmless
    with current kbuild.
    This bug was exposed when we rearranged the options to gcc.

    Signed-off-by: Sam Ravnborg <>
    scripts/Kbuild.include | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)

    diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
    index 982dcae..936940b 100644
    --- a/scripts/Kbuild.include
    +++ b/scripts/Kbuild.include
    @@ -144,7 +144,9 @@ ld-option = $(call try-run,\
    build := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/ obj

    # Prefix -I with $(srctree) if it is not an absolute path.
    -addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1))) $(1)
    +# skip if -I has no parameter
    +addtree = $(if $(patsubst -I%,%,$(1)), \
    +$(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1))) $(1))

    # Find all -I options and call addtree
    flags = $(foreach o,$($(1)),$(if $(filter -I%,$(o)),$(call addtree,$(o)),$(o)))

     \ /
      Last update: 2008-12-20 15:33    [W:0.019 / U:17.264 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site