Messages in this thread | | | Date | Sat, 20 Dec 2008 21:24:25 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH] posix-timers: CLOCK_MONOTONIC_RAW: fix the usage of ->it_clock |
| |
On 12/20, Thomas Gleixner wrote: > > On Sat, 20 Dec 2008, Oleg Nesterov wrote: > > > -static int common_timer_create(struct k_itimer *new_timer) > > +static inline int > > +__common_timer_init(struct k_itimer *timer, enum hrtimer_mode mode) > > { > > - hrtimer_init(&new_timer->it.real.timer, new_timer->it_clock, 0); > > + clockid_t clock_id = timer->it_clock ? > > + CLOCK_MONOTONIC : CLOCK_REALTIME; > > + hrtimer_init(&timer->it.real.timer, clock_id, mode); > > return 0; > > } > > No, this is wrong. We do not want to create a timer for > CLOCK_MONOTONIC_RAW.
OK, thanks.
I thought that the intent was to allow the creation.
Then we should we shoould add clock_monotonic_raw->timer_create() which returns -EINVAL ?
Oleg.
| |