Messages in this thread | | | Date | Fri, 19 Dec 2008 13:59:09 +0530 | From | Vaidyanathan Srinivasan <> | Subject | Re: [PATCH v7 0/8] Tunable sched_mc_power_savings=n |
| |
* Ingo Molnar <mingo@elte.hu> [2008-12-18 21:31:40]:
> > * Ingo Molnar <mingo@elte.hu> wrote: > > > thanks, applied - and i started testing them. [...] > > the sched.h bits needed the small fix below. (struct sched_domain is not > defined on UP)
Thanks Ingo. I will watch out for such errors next time.
Signed-off-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
--Vaidy
> > Ingo > > -------------> > From edb4c71953409c1deac1a80528ac0aa768762b33 Mon Sep 17 00:00:00 2001 > From: Ingo Molnar <mingo@elte.hu> > Date: Thu, 18 Dec 2008 21:30:23 +0100 > Subject: [PATCH] sched: move test_sd_parent() to an SMP section of sched.h > > Impact: build fix > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > --- > include/linux/sched.h | 18 +++++++++--------- > 1 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 5a933d9..e5f928a 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -920,6 +920,15 @@ extern void partition_sched_domains(int ndoms_new, struct cpumask *doms_new, > struct sched_domain_attr *dattr_new); > extern int arch_reinit_sched_domains(void); > > +/* Test a flag in parent sched domain */ > +static inline int test_sd_parent(struct sched_domain *sd, int flag) > +{ > + if (sd->parent && (sd->parent->flags & flag)) > + return 1; > + > + return 0; > +} > + > #else /* CONFIG_SMP */ > > struct sched_domain_attr; > @@ -1431,15 +1440,6 @@ struct task_struct { > #endif > }; > > -/* Test a flag in parent sched domain */ > -static inline int test_sd_parent(struct sched_domain *sd, int flag) > -{ > - if (sd->parent && (sd->parent->flags & flag)) > - return 1; > - > - return 0; > -} > - > /* > * Priority of a process goes from 0..MAX_PRIO-1, valid RT > * priority is 0..MAX_RT_PRIO-1, and SCHED_NORMAL/SCHED_BATCH
| |