lkml.org 
[lkml]   [2008]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH, v5] 9p: don't print IS_ERR strings
    NAK - the print is a debug to mark function entry when debugging is on
    -- it is not intended to show only success. If an erroneous s will
    cause the print to break then perhaps it should be parameterized, but
    the entire print shouldn't be pushed inside the if statement.

    -eric


    On Fri, Dec 19, 2008 at 2:47 PM, Duane Griffin <duaneg@dghda.com> wrote:
    > Move the printk inside the !IS_ERR test.
    >
    > Cc: Eric Van Hensbergen <ericvh@gmail.com>
    > Cc: Ron Minnich <rminnich@sandia.gov>
    > Cc: Latchesar Ionkov <lucho@ionkov.net>
    > Cc: v9fs-developer@lists.sourceforge.net
    > Signed-off-by: Duane Griffin <duaneg@dghda.com>
    > ---
    >
    > Unchanged from original version.
    >
    > fs/9p/vfs_inode.c | 5 +++--
    > 1 files changed, 3 insertions(+), 2 deletions(-)
    >
    > diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
    > index 8fddfe8..c50d555 100644
    > --- a/fs/9p/vfs_inode.c
    > +++ b/fs/9p/vfs_inode.c
    > @@ -1022,9 +1022,10 @@ v9fs_vfs_put_link(struct dentry *dentry, struct nameidata *nd, void *p)
    > {
    > char *s = nd_get_link(nd);
    >
    > - P9_DPRINTK(P9_DEBUG_VFS, " %s %s\n", dentry->d_name.name, s);
    > - if (!IS_ERR(s))
    > + if (!IS_ERR(s)) {
    > + P9_DPRINTK(P9_DEBUG_VFS, " %s %s\n", dentry->d_name.name, s);
    > __putname(s);
    > + }
    > }
    >
    > /**
    > --
    > 1.6.0.4
    >
    >


    \
     
     \ /
      Last update: 2008-12-19 23:17    [W:0.024 / U:29.512 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site