lkml.org 
[lkml]   [2008]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/14] kmemleak: Add the base support

* Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> On Fri, Dec 19, 2008 at 8:13 PM, Catalin Marinas
> <catalin.marinas@arm.com> wrote:
> > This patch adds the base support for the kernel memory leak
> > detector. It traces the memory allocation/freeing in a way similar to
> > the Boehm's conservative garbage collector, the difference being that
> > the unreferenced objects are not freed but only shown in
> > /sys/kernel/debug/kmemleak. Enabling this feature introduces an
> > overhead to memory allocations.
> >
> > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Ingo Molnar <mingo@elte.hu>
> > Cc: Pekka Enberg <penberg@cs.helsinki.fi>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> Looks good to me. I have only reviewed this lightly but all my major
> concerns have been addressed so feel free to add my:
>
> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>

Andrew, do you have any principial objections against having this in
v2.6.29?

This dragged on for a long time, and i think the debug output is useful
and it tells us something that we have no other tool for at the moment to
figure out. We can tell stuck tasks, stuck files and other stuck resources
easily - we can even see fast slab leaks, but we cannot really tell slow,
long-term slab leaks apart from regular slab prints, and we cannot
identify the source of them. The false positive rate of kmemleak has
decreased substantially as well, over the earlier design.

Ingo


\
 
 \ /
  Last update: 2008-12-19 23:15    [W:0.228 / U:0.484 seconds]
©2003-2011 Jasper Spaans. Advertise on this site