lkml.org 
[lkml]   [2008]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] printk: fix discarding message when recursion_bug

    * Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:

    > From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
    >
    > Impact: fix
    >
    > When recursion_bug is true, kernel discards original message because printk_buf
    > contains recursion_bug_msg with NULL terminator. The sizeof(recursion_bug_msg)
    > makes this, use strlen() to get correct length without NULL terminator.
    >
    > Reported-by: Toshikazu Nakayama <nakayama.ts@ncos.nec.co.jp>
    > Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
    > ---
    > kernel/printk.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)

    Good one - applied to tip/core/printk, thanks!

    Btw., i'm curious: in what situation was such recursion observed, and how
    did the kernel behave? You saw a truncated recursion message in dmesg - or
    was it worse?

    Ingo


    \
     
     \ /
      Last update: 2008-12-19 22:57    [W:0.024 / U:0.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site