lkml.org 
[lkml]   [2008]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix some code style that line over 80 characters
On Thu, Dec 18, 2008 at 07:30:59PM +0000, Russell King wrote:
> On Thu, Dec 18, 2008 at 11:26:17AM -0800, Randy Dunlap wrote:
> > On Wed, 10 Dec 2008 18:01:16 +0300 Alexey Dobriyan wrote:
> >
> > > On Wed, Dec 10, 2008 at 09:51:43PM +0800, Helight.Xu wrote:
> > > > -static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> > > > +static inline struct
> > > > +s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> > >
> > > NAK!
> >
> > OK, but please includes reason(s) for NAKs...
>
> I can provide a reason - it splits "struct" and the structure name
> across different lines. That manes 'struct s3c2410_platform_i2c'
> hard to grep for.
yes, it should be:
static inline
struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
>
> --
> Russell King
> Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
> maintainer of:

--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org
My Studio: http://dim4.cn


\
 
 \ /
  Last update: 2008-12-19 07:37    [W:0.071 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site