lkml.org 
[lkml]   [2008]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Stop scaring users with "treason uncloaked!"
From
From: Matt Mackall <mpm@selenic.com>
Date: Thu, 18 Dec 2008 21:49:21 -0600

> On Thu, 2008-12-18 at 16:15 -0800, David Miller wrote:
> > From: Matt Mackall <mpm@selenic.com>
> > Date: Thu, 18 Dec 2008 17:50:34 -0600
> >
> > > If you want, we can instead say "Peer %d unexpectedly shrunk window...".
> > > So long as the scary bit is gone, I don't care.
> >
> > Since we have established that the blame is equally possible to
> > be the local as the remote system, something like:
> >
> > TCP: Unexpected shrink of advertised window detected ...
> >
> > is probably the best.
>
> How's this:
>
> The original message was unhelpful and extremely alarming to our poor
> users, despite its charm. Make it less frightening.
>
> Signed-off-by: Matt Mackall <mpm@selenic.com>

Looks good, applied, thanks Matt.


\
 
 \ /
  Last update: 2008-12-19 04:57    [W:0.048 / U:0.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site