Messages in this thread | | | Date | Thu, 18 Dec 2008 15:33:35 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: traps.c declare functions before they get used |
| |
* Jaswinder Singh <jaswinderlinux@gmail.com> wrote:
> Hello Ingo, > > On Wed, Dec 17, 2008 at 1:49 AM, Ingo Molnar <mingo@elte.hu> wrote: > >> +#ifndef CONFIG_MATH_EMULATION > >> asmlinkage void math_emulate(long); > >> #endif > > > > uhm, shouldnt that #ifndef CONFIG_MATH_EMULATION be #ifdef > > CONFIG_MATH_EMULATION? > > > > Sorry, but it seems correct to me in traps case will be opposite. > > If someone tries to access math_emulate() and MATH_EMULATION is not > defined then he will be trapped ;-)
you should build-test your patch with MATH_EMULATION enabled.
Ingo
| |