Messages in this thread | | | Date | Thu, 18 Dec 2008 14:31:34 +0100 | From | Ingo Molnar <> | Subject | Re: [patch] x86: convert rdtscll() to use __native_read_tsc |
| |
* Ken Chen <kenchen@google.com> wrote:
> On Tue, Dec 16, 2008 at 2:15 AM, Ingo Molnar <mingo@elte.hu> wrote: > > agreed mostly, with this twist: vdso inlining dependencies should be > > expressed explicitly, via: > > > > native_vread_tsc() > > > > but we can also make native_read_tsc() __always_inline [it's a single > > instruction with basically no preparatory halo around that instruction] > > and document the vdso detail there. > > Given that vdso already uses the inline version of __native_read_tsc, we > don't really have churn all that code around. I also take your analysis > as there is no issue in converting rdtscll() to __native_read_tsc(). > Would it be possible for you to merge the patch then?
yep, i already did that when i replied to your mail, it's in tip/x86/time.
Ingo
| |