lkml.org 
[lkml]   [2008]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: trace: fix task state printout

* Steven Rostedt <rostedt@goodmis.org> wrote:

>
> On Wed, 17 Dec 2008, Thomas Gleixner wrote:
>
> > Impact: tracer task state decoding is wrong, size check is buggy
>
> The Imact line seems more of a subject line. The real Impact line should
> be something like:
>
> Impact: fix wrong decoding of task state int tracer
>
> Keyword is 'fix'
>
> >
> > The tracing code has interesting varieties of printing out task state.
> > Unfortunalely only one of the instances is correct as it copies the
> > code from sched.c:sched_show_task(). The others are plain wrong as
> > they treatthe bitfield as an integer offset into the character array.
> > Also the size check of the character array is wrong as it includes the
> > trailing \0.
> >
> > Use a common state decoder inline which does the Right Thing.
> >
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> Acked-by: Steven Rostedt <srostedt@redhat.com>
>
> Ingo, this is a low risk fix that probably should be pushed towards
> Linus for inclusion into 2.6.28.

ok, we can do that after a few days of testing.

Btw., note that when capturing traces via trace_pipe, i still see frequent
mistakes of PIDs being matched up to the wrong 'comm' string

loop-1sec-2895 ...
Xorg-2895 ...

the Xorg-2895 is bogus. I have been seeing these for a long time and
thought we fixed it, but i noticed them yesterday once more, while i was
tracing some code. Any ideas about what's wrong there?

Ingo


\
 
 \ /
  Last update: 2008-12-18 13:05    [W:0.049 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site