lkml.org 
[lkml]   [2008]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [Patch 3/3] via-sdmmc: via-sdmmc.h
Date
From
> > 
>
> The order of your patches is reversed, you add the
> Kconfig/Makefile changes last so that the tree stays
> 'bisectable', i.e. you don't have a broken build in the
> middle between your patches.
>
> Since your header file is not an interface but only used in a
> single source file, I would also suggest merging it into the
> main via-sdmmc.c file, add changing Kconfig/Makefile in the
> same patch.
>
> Arnd <><
>

Tks, I'll notice this next time.
\
 
 \ /
  Last update: 2008-12-17 12:17    [W:0.557 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site