Messages in this thread | | | Subject | Re: [PATCH 01/15] kmemleak: Add the base support | From | Catalin Marinas <> | Date | Wed, 17 Dec 2008 09:44:56 +0000 |
| |
On Tue, 2008-12-16 at 11:36 -0800, Paul E. McKenney wrote: > On Wed, Dec 10, 2008 at 06:26:59PM +0000, Catalin Marinas wrote: > > This patch adds the base support for the kernel memory leak > > detector. It traces the memory allocation/freeing in a way similar to > > the Boehm's conservative garbage collector, the difference being that > > the unreferenced objects are not freed but only shown in > > /sys/kernel/debug/memleak. Enabling this feature introduces an > > overhead to memory allocations. > > Looks good to me from an RCU viewpoint! > > Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Thanks for reviewing it.
FYI, in the version I'm going to post this week I added another mutex to ensure the exclusive opening of the /sys/kernel/debug/memleak file as one can now use this file to configure kmemleak at run-time. The RCU locking isn't affected and I'll add your "Reviewed-by:" line.
-- Catalin
| |