Messages in this thread | | | From | "Dan Terpstra" <> | Subject | RE: [Perfctr-devel] [patch] Performance Counters for Linux, v4 | Date | Tue, 16 Dec 2008 21:23:32 -0500 |
| |
> Peter Zijlstra writes: > > > On Mon, 2008-12-15 at 23:11 +1100, Paul Mackerras wrote: > > > I think the core should put together a list of counters and counter > > > groups that it would like to have on the PMU simultaneously and then > > > make one call to the arch layer to ask if that is possible. That > > > could either return success or failure. If it returns failure then > > > the core needs to ask for something less, or something different. I'm > > > not sure how the core should choose what to ask for instead, though. > > > > I think the constraint set should be applied when we add to a group, if > > when we add a counter to the group, the result isn't schedulable > > anymore, we should fail the group addition - and thereby the counter > > creation. > > > > This would leave us with groups that are always schedulable in an atomic > > fashion. > > I agree that if adding a counter to a group results in that group not > being schedulable any more, we should fail the addition. > That's what PAPI does. In userspace. Using libpfm. Before counting anything. On linux, AIX, Windows, Cray... Talking to perfmon, perfctr, our own drivers, and maybe someday even the linux performance counter subsystem. - d
| |